Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new supported assets #3153

Merged
merged 13 commits into from
Sep 13, 2024
Merged

chore: add new supported assets #3153

merged 13 commits into from
Sep 13, 2024

Conversation

LuizAsFight
Copy link
Contributor

@LuizAsFight LuizAsFight commented Sep 12, 2024

Release notes

In this release, we:

  • Added new supported assets based on the points program

Summary

Adding a set of assets that will be supported by default in the apps consuming this list of assets.
It was based on the tokens configuration for Points Program

How to get this list

I created an array of assets with ethereum configs only (address, decimals, symbol), then created a generate script that will calculate the assetIds on fuel side and complete the network configs, according to chainIds provided for eth and fuel network.
Would be a good idea to include it in TS SDK, making it easier to maintain the assets list

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:29pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 13, 2024 2:29pm

@github-actions github-actions bot added the chore Issue is a chore label Sep 12, 2024
Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #3153 will not alter performance

Comparing lf/chore/include-new-assets (be14ce3) with master (3409c10)

Summary

✅ 21 untouched benchmarks

Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3153-20240912211325

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.08%(+0%) 71.64%(+0.03%) 75.73%(+0%) 77.19%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
78.08%
(+1.37%)
84%
(+0%)
88.81%
(+0%)

@arboleya arboleya merged commit 6a920ee into master Sep 13, 2024
25 checks passed
@arboleya arboleya deleted the lf/chore/include-new-assets branch September 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include assets for Mainnet
4 participants