-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add new supported assets #3153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3153 will not alter performanceComparing Summary
|
…nclude-new-assets
…ls-ts into lf/chore/include-new-assets
This PR is published in NPM with version 0.0.0-pr-3153-20240912211325 |
…ls-ts into lf/chore/include-new-assets
Torres-ssf
reviewed
Sep 13, 2024
arboleya
approved these changes
Sep 13, 2024
arboleya
requested review from
digorithm,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
September 13, 2024 14:34
petertonysmith94
approved these changes
Sep 13, 2024
Coverage Report:
Changed Files:
|
Torres-ssf
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Summary
Adding a set of assets that will be supported by default in the apps consuming this list of assets.
It was based on the tokens configuration for Points Program
How to get this list
I created an array of assets with ethereum configs only (address, decimals, symbol), then created a generate script that will calculate the assetIds on fuel side and complete the network configs, according to chainIds provided for eth and fuel network.
Would be a good idea to include it in TS SDK, making it easier to maintain the assets list
Checklist